Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat:timeline): fix y2 to be optional #1622

Merged
merged 1 commit into from
Jul 21, 2023
Merged

fix(chat:timeline): fix y2 to be optional #1622

merged 1 commit into from
Jul 21, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jul 21, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Jul 21, 2023

Preview is ready!

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #1622 (0ccc4da) into master (12c2f86) will not change coverage.
The diff coverage is n/a.

❗ Current head 0ccc4da differs from pull request most recent head 9797a5d. Consider uploading reports for the commit 9797a5d to get more accurate results

@@           Coverage Diff           @@
##           master    #1622   +/-   ##
=======================================
  Coverage   95.54%   95.54%           
=======================================
  Files         277      277           
  Lines        8624     8624           
  Branches     1681     1681           
=======================================
  Hits         8240     8240           
  Misses        319      319           
  Partials       65       65           
Impacted Files Coverage Δ
packages/chart/timeline/timeline.component.ts 91.54% <ø> (ø)

... and 1 file with indirect coverage changes

@cipchk cipchk merged commit b565ddf into master Jul 21, 2023
@cipchk cipchk deleted the issues-timeline branch July 21, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants